Re: [PATCH 13/18] fill_sha1_file: write "boring" characters

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 5, 2016, 19:35 UTC
Message-ID: <xmqqvax6oagq.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CA+P7+xrBX684an5EzUUk+_Dtu6Ep_F+nB1JyWDWsZjUANWcFoA@mail.gmail.com>

Jacob Keller <jacob.keller@gmail.com> writes:

Show 8 quoted lines

>> The cost of fill function having to do the same thing repeatedly is
>> negligible, so I am OK with the result, but for fairness, this was
>> not "make the callers do this extra thing", but was "the caller can
>> prepare these unchanging parts just once, and the fill function that
>> is repeatedly run does not have to."
>
> Sure, but it's a pretty minor optimization and I think the result is
> easier to understand.

Yes; in case it wasn't clear, my comment was merely for fairness to the original code. I do agree that the end result of this series makes a very pleasant read.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.