Re: [PATCH 01/18] t5613: drop reachable_via function
- From
Jacob Keller <jacob.keller@gmail.com>
- Date
- Oct 4, 2016, 05:48 UTC
- Message-ID
- <CA+P7+xq3G=CNHNNQ5YpkHkud_5SUrTBOwZ3y7d8DvM9nKyXV9g@mail.gmail.com>
- In-Reply-To
- <20161003203350.3u6ddr6ndr3jwr74@sigill.intra.peff.net>
On Mon, Oct 3, 2016 at 1:33 PM, Jeff King <peff@peff.net> wrote:
Show 7 quoted lines
> This function was never used since its inception in dd05ea1 > (test case for transitive info/alternates, 2006-05-07). > Which is just as well, since it mutates the repo state in a > way that would invalidate further tests, without cleaning up > after itself. Let's get rid of it so that nobody is tempted > to use it. >
Makes sense. It wouldn't be a good idea to leave this around since it didn't clean up after itself. Curious why no test actually used it though..
Thanks, Jake