Re: [PATCH 07/18] link_alt_odb_entry: handle normalize_path errors

From: Bryan Turner <bturner@atlassian.com>
Date: Nov 8, 2016, 19:27 UTC
Message-ID: <CAGyf7-HVUN-kHhmccoYUVVDE_xJt1UsiE8bxZiADsW5GFGr+OA@mail.gmail.com>
In-Reply-To: <20161108053333.jta7bmqsyvy2ijoh@sigill.intra.peff.net>

Show 16 quoted lines

>
>> Is there anything I can do to help? I'm happy to test out changes.
>
> The patch at the end of his mail obviously passes the newly-added tests
> for me, but please confirm that it fixes your test suite.
>
> I gather your suite is about noticing behavior changes between different
> versions. For cases where we know there is an obvious right behavior, it
> would be nice if you could contribute them as patches to git's test
> suite. This case was overlooked because there was no test coverage at
> all.
>
> Barring that, running your suite and giving easily-reproducible problem
> reports is valuable. The earlier the better. So I am happy to see this
> on -rc0, and not on the final release. Periodically running it on
> "master" during the development cycle would have caught it even sooner.

I've applied your patch to the tip of the 2.11.0-rc0 tag (just to make sure I don't accidentally pick up anything else on master; I'll test that separately) and my full test suite passes without issue.

I'm going to investigate whether I can setup a version of this build that runs "periodically" (I'm not sure what that period will be) against git/git master. I've got a lot of the infrastructure in place, but I'm going to need to automate a few things to make it really viable.

As for contributing extensions to the test suite, that's a good idea. I need to fast track getting a development environment setup.