Re: [PATCH 01/18] t5613: drop reachable_via function

From: Jeff King <peff@peff.net>
Date: Oct 4, 2016, 13:43 UTC
Message-ID: <20161004134339.pn4elyuixslsaya4@sigill.intra.peff.net>
In-Reply-To: <CA+P7+xq3G=CNHNNQ5YpkHkud_5SUrTBOwZ3y7d8DvM9nKyXV9g@mail.gmail.com>

On Mon, Oct 03, 2016 at 10:48:31PM -0700, Jacob Keller wrote:

Show 12 quoted lines

> On Mon, Oct 3, 2016 at 1:33 PM, Jeff King <peff@peff.net> wrote:
> > This function was never used since its inception in dd05ea1
> > (test case for transitive info/alternates, 2006-05-07).
> > Which is just as well, since it mutates the repo state in a
> > way that would invalidate further tests, without cleaning up
> > after itself. Let's get rid of it so that nobody is tempted
> > to use it.
> >
> 
> Makes sense. It wouldn't be a good idea to leave this around since it
> didn't clean up after itself. Curious why no test actually used it
> though..

I wondered that, too. Sometimes in cases like this a call got dropped during a re-roll on the list. But the original email:

  http://public-inbox.org/git/20060507181947.GE23738@admingilde.org/

has the problem, too. So probably it was just leftover cruft that was made obsolete even before it hit the list.

-Peff