Re: [PATCH 10/18] alternates: provide helper for allocating alternate

From: Jacob Keller <jacob.keller@gmail.com>
Date: Oct 4, 2016, 06:09 UTC
Message-ID: <CA+P7+xpgNo1d_6h6XZneEei6zbV02GcC8o+e+51wpnAeenJz=g@mail.gmail.com>
In-Reply-To: <20161003203531.bppczvzmdfumtnb2@sigill.intra.peff.net>

On Mon, Oct 3, 2016 at 1:35 PM, Jeff King <peff@peff.net> wrote:

Show 7 quoted lines

> Allocating a struct alternate_object_database is tricky, as
> we must over-allocate the buffer to provide scratch space,
> and then put in particular '/' and NUL markers.
>
> Let's encapsulate this in a function so that the complexity
> doesn't leak into callers (and so that we can modify it
> later).

The overall way this was broken up is definitely a lot of patches to follow but understanding the end goal this is a huge improvement in code maintainability here. This original allocation is indeed very tricky.

Thanks, Jake

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.