Re: [PATCH v2 0/5] sparse-index: improve clear_skip_worktree_from_present_files()

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 27, 2024, 21:46 UTC
Message-ID: <xmqqv81uqcsi.fsf@gitster.g>
In-Reply-To: <pull.1754.v2.git.1719412192.gitgitgadget@gmail.com>

"Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 15 quoted lines

> Updates in v2
> =============
>
> Thanks to Elijah for a thorough review, leading to valuable improvements.
>
>  * I was mistaken that the sparse index was required for this logic to
>    happen. This has changed several descriptions across the commit messages.
>  * The final lstat() in path_found() was not needed, so is removed in v2.
>    This saves even more time and lstat() calls, updating the stats.
>  * Elijah created a particularly nasty example for testing, which I include
>    in my final patch. He gets a "Helped-by" credit for this.
>  * Several comments, variables, and other improvements based on Elijah's
>    recommendations.
>
> Thanks, Stolee

Thanks, both.  This round was a pleasant read.

Let's mark it for 'next' soonish.