Re: [PATCH 1/5] sparse-index: refactor skip worktree retry logic

From: Derrick Stolee <stolee@gmail.com>
Date: Jun 26, 2024, 12:42 UTC
Message-ID: <a4edb8fb-5ed4-401f-819f-4034f67cd27e@gmail.com>
In-Reply-To: <CABPp-BF=8y2yC0WvF7BhNFiyW10A_yKs5s6euEi3FwYSsmHnWg@mail.gmail.com>

On 6/24/24 6:12 PM, Elijah Newren wrote:

Show 15 quoted lines

> On Thu, Jun 20, 2024 at 10:11 AM Derrick Stolee via GitGitGadget
> <gitgitgadget@gmail.com> wrote:
>>
>> From: Derrick Stolee <stolee@gmail.com>
>>
>> The clear_skip_worktree_from_present_files() method was introduced in
>> af6a51875a (repo_read_index: clear SKIP_WORKTREE bit from files present
>> in worktree, 2022-01-14) to help cases where the sparse index is enabled
> 
> s/index/checkout/; the code in af6a51875a made no assumptions about
> sparse index being enabled.
> 
>> but some paths outside of the sparse-checkout cone also exist on disk.
> 
> s/cone//; it wasn't specific to cone mode.

Thanks for the context that this is a generic sparse-checkout feature, and is not limited to the sparse index (which is limited to cone mode). I made assumptions based on the code's location in sparse-index.c.

Show 5 quoted lines

> Although I had a few wording quibbles with the commit message, overall
> the commit message was clear about what you were trying to achieve.
> Also, the change in this patch is a straightforward splitting of the
> old function into three new functions (one of which is the overall
> driver calling the other two).

I have reworded locally and will have a v2 later today with a better message. Thanks for your attention to detail.

Thanks, -Stolee