From: Junio C Hamano Date: Thu, 27 Jun 2024 21:46:37 GMT Subject: Re: [PATCH v2 0/5] sparse-index: improve clear_skip_worktree_from_present_files() Message-ID: In-Reply-To: "Derrick Stolee via GitGitGadget" writes: > Updates in v2 > ============= > > Thanks to Elijah for a thorough review, leading to valuable improvements. > > * I was mistaken that the sparse index was required for this logic to > happen. This has changed several descriptions across the commit messages. > * The final lstat() in path_found() was not needed, so is removed in v2. > This saves even more time and lstat() calls, updating the stats. > * Elijah created a particularly nasty example for testing, which I include > in my final patch. He gets a "Helped-by" credit for this. > * Several comments, variables, and other improvements based on Elijah's > recommendations. > > Thanks, Stolee Thanks, both. This round was a pleasant read. Let's mark it for 'next' soonish.