Re: [PATCH 5/5] sparse-index: improve lstat caching of sparse paths

From: Elijah Newren <newren@gmail.com>
Date: Jun 28, 2024, 00:10 UTC
Message-ID: <CABPp-BEHP1h244etkRANCiY9Oz6qsQrNB+Sk4s=kXdE9vucfNQ@mail.gmail.com>
In-Reply-To: <cfb20e54-eee5-4043-abcb-63c8211635d3@gmail.com>

On Wed, Jun 26, 2024 at 6:06 AM Derrick Stolee <stolee@gmail.com> wrote:

>
> On 6/24/24 6:14 PM, Elijah Newren wrote:

[...]

Show 17 quoted lines

> > Further, you can recompile the git version in use in another window,
> > then come back to this one and run 'rm trace' followed by the last two
> > commands to retest.
> >
> > The commands above create a 'gvfs-like-git-bomb' git directory that
> > has 1,000,001 files in HEAD.
> >
> > With this test directory, before applying this patch, I see:
> >      ..sparse_lstat_count:722011
> > After applying this patch I see
> >      ..sparse_lstat_count:135
> > and with a slight tweak to your patch I see
> >      ..sparse_lstat_count:125
> > I'll comment on the slight tweak at the end of the patch.
>
> Thanks for these numbers! Are you willing to keep that example repo
> on GitHub so I can refer to it in the message?

Sure, I've had it up for several years already without change (though the anachronistic 'gvfs' in the repository name feels like it should be updated...)