git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] MIDX: revert the default version to v1

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 16, 2026, 19:38 UTC
Message-ID
<xmqqv7dqzoeh.fsf@gitster.g>
In-Reply-To
<xmqq8qam217m.fsf_-_@gitster.g>
Junio C Hamano <gitster@pobox.com> writes:
Show 18 quoted lines
> From: Jeff King <peff@peff.net>
>
> Dscho reports that fetching into a repository with Git 2.54-rc2 made
> it unusable with Git 2.53, as the recent code by default writes
> version 2 multi-pack-index files.  Version 2 is the base of more
> advanced features to come, but using it where these features are not
> used is a strict regression.
>
> As deployed versions of Git and its reimplementations may not be
> ready for the format bump, let's revert the default version of MIDX
> file we write back to V1, and adjust tests that exercise V2-specific
> features to explicitly request V2.
>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> ---
>
>  * Let me reword the proposed log message to talk about background a
>    bit more why we want to do this.

Of course, the tip of tb/incremental-midx-part-3.3 needs to be adjusted with this before merging to 'seen'. I think my tree is getting ready to push the "revert the default" down to 'master'.

----- >8 ---- SQUASH??? adjust for MIDX version default reversion

diff --git a/t/t7705-repack-incremental-midx.sh b/t/t7705-repack-incremental-midx.sh
index 562554e69b..7eb1109ec5 100755
--- a/t/t7705-repack-incremental-midx.sh
+++ b/t/t7705-repack-incremental-midx.sh
@@ -63,6 +63,9 @@ create_layers () {
 	done
 }
 
+# These incremental MIDX tests requires the V2 format.
+git config --global midx.version 2
+
 test_expect_success '--write-midx=incremental without --geometric' '
 	git init incremental-without-geometric &&
 	(
Previous: Junio C HamanoNext: Junio C Hamano
Message 20 of 30 in “[ANNOUNCE] Git v2.54.0-rc2”
  1. Junio C HamanoApr 14, 2026
  2. MIDX woes, was Re: [ANNOUNCE] Git v2.54.0-rc2Johannes Schindelin, Apr 15, 2026
  3. Junio C HamanoApr 15, 2026
  4. Jeff KingApr 16, 2026
  5. Jeff KingApr 16, 2026
  6. Derrick StoleeApr 16, 2026
  7. Junio C HamanoApr 16, 2026
  8. Taylor BlauApr 16, 2026
  9. Derrick StoleeApr 19, 2026
  10. Junio C HamanoApr 20, 2026
  11. Taylor BlauApr 16, 2026
  12. Jeff KingApr 16, 2026
  13. Junio C HamanoApr 16, 2026
  14. Junio C HamanoApr 16, 2026
  15. Jeff KingApr 16, 2026
  16. Junio C HamanoApr 16, 2026
  17. Jeff KingApr 16, 2026
  18. Junio C HamanoApr 17, 2026
  19. MIDX: revert the default version to v1Junio C Hamano, Apr 16, 2026
  20. Junio C HamanoApr 16, 2026
  21. Junio C HamanoApr 16, 2026
  22. Taylor BlauApr 16, 2026
  23. Jeff KingApr 16, 2026
  24. Junio C HamanoApr 16, 2026
  25. Jeff KingApr 16, 2026
  26. Jeff KingApr 16, 2026
  27. Taylor BlauApr 16, 2026
  28. Jeff KingApr 16, 2026
  29. Junio C HamanoApr 17, 2026
  30. Elijah NewrenApr 17, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.