Re: [PATCH] MIDX: revert the default version to v1
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Apr 16, 2026, 19:38 UTC
- Message-ID
- <xmqqv7dqzoeh.fsf@gitster.g>
- In-Reply-To
- <xmqq8qam217m.fsf_-_@gitster.g>
Junio C Hamano <gitster@pobox.com> writes:
Show 18 quoted lines
> From: Jeff King <peff@peff.net> > > Dscho reports that fetching into a repository with Git 2.54-rc2 made > it unusable with Git 2.53, as the recent code by default writes > version 2 multi-pack-index files. Version 2 is the base of more > advanced features to come, but using it where these features are not > used is a strict regression. > > As deployed versions of Git and its reimplementations may not be > ready for the format bump, let's revert the default version of MIDX > file we write back to V1, and adjust tests that exercise V2-specific > features to explicitly request V2. > > Signed-off-by: Junio C Hamano <gitster@pobox.com> > --- > > * Let me reword the proposed log message to talk about background a > bit more why we want to do this.
Of course, the tip of tb/incremental-midx-part-3.3 needs to be adjusted with this before merging to 'seen'. I think my tree is getting ready to push the "revert the default" down to 'master'.
----- >8 ---- SQUASH??? adjust for MIDX version default reversion
diff --git a/t/t7705-repack-incremental-midx.sh b/t/t7705-repack-incremental-midx.sh index 562554e69b..7eb1109ec5 100755 --- a/t/t7705-repack-incremental-midx.sh +++ b/t/t7705-repack-incremental-midx.sh @@ -63,6 +63,9 @@ create_layers () { done } +# These incremental MIDX tests requires the V2 format. +git config --global midx.version 2 + test_expect_success '--write-midx=incremental without --geometric' ' git init incremental-without-geometric && (