Re: MIDX woes, was Re: [ANNOUNCE] Git v2.54.0-rc2
- From
Jeff King <peff@peff.net>
- Date
- Apr 16, 2026, 23:29 UTC
- Message-ID
- <20260416232941.GD1904316@coredump.intra.peff.net>
- In-Reply-To
- <aeFF5s5m76Yz7F/Q@nand.local>
On Thu, Apr 16, 2026 at 04:26:14PM -0400, Taylor Blau wrote:
Show 20 quoted lines
> Yeah, I agree, and sorry for the trouble here. A few thoughts: > > - In the immediate term, we should downgrade the default format to > write V1 MIDXs for the compatibility issues pointed out by this > thread. That would seem to be the minimal thing to do to make sure > that the 2.54 release is as smooth as possible. > > - In the medium term (i.e., on the other side of 2.54) we should > implement the changes that Peff sketched earlier in the thread to > make loading the MIDX robust towards unrecognized versions. > > Of course, that doesn't fix any old clients who don't upgrade and at > some point want to fetch from or otherwise interact with a repository > that has a V2 MIDX. But it does improve things for, say, users that > are on an eventual 2.55 if we make the V1->V2 by default change in > 2.56. > > - In the long term (i.e., in 2.56 or otherwise in a release after the > above change is implemented) we should make V2 the default format for > MIDXs.
That all seems reasonable. I think the only question is how long the "in the long term" period should be. Two versions is not very long, especially for people who are using OS packages (think moving from one Debian stable release to another). But that can be sorted out later.
-Peff