git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: MIDX woes, was Re: [ANNOUNCE] Git v2.54.0-rc2

From
Derrick Stolee <stolee@gmail.com>
Date
Apr 16, 2026, 13:24 UTC
Message-ID
<621c9da9-2ec0-462d-ae51-0be5e0ca6ab2@gmail.com>
In-Reply-To
<20260416053435.GA646718@coredump.intra.peff.net>
On 4/16/2026 1:34 AM, Jeff King wrote:
Show 9 quoted lines
> On Thu, Apr 16, 2026 at 01:17:33AM -0400, Jeff King wrote:
> 
>> I think removing the .midx file (and optionally regenerating with the
>> old version) would be the appropriate workaround, but I wonder how hard
>> it would be to go back to generating v1 midx files by default. I know v2
>> is a building block for more advanced features, but for those who are
>> not using those features yet it is a strict regression.
> 
> I think doing so is just this one-liner:
...
> and then here we need to use v2 for the new compaction feature:
...
Show 8 quoted lines
> So that would make things work as usual for anybody mixing and matching
> multiple versions of Git, but does make life slightly worse for anybody
> who wants to use the new feature (they have to set the config). We might
> need a doc update, or possibly even to automatically default to v2 when
> using the compact command. But that could come post-2.54.
> 
> At this point I'll stop poking and speculating and see what direction
> Taylor suggests. ;)

I think this is a good change to make. This fits with the standard approach of not making breaking file changes by default, but letting users opt-in to new versions (at least for a few major releases).

The part that is striking about Johannes' report is that this happens on a fetch, so it is being written automatically by normal maintenance activities in that case. Without downgrading the default version back to a compatible version, deleting the multi-pack-index(es) will not keep the repo in a good state.

As for the multi-pack-index being optional, I agree that we _could_ have a more graceful fallback to the pack-indexes when we don't recognize the file format version. This should still be a very visible warning as it can be an important performance feature, so users should be notified when it isn't working as they expect. (This can be done separately from this late-in-rc change for the default version.)

Thanks, -Stolee

Previous: Jeff KingNext: Junio C Hamano
Message 6 of 30 in “[ANNOUNCE] Git v2.54.0-rc2”
  1. Junio C HamanoApr 14, 2026
  2. MIDX woes, was Re: [ANNOUNCE] Git v2.54.0-rc2Johannes Schindelin, Apr 15, 2026
  3. Junio C HamanoApr 15, 2026
  4. Jeff KingApr 16, 2026
  5. Jeff KingApr 16, 2026
  6. Derrick StoleeApr 16, 2026
  7. Junio C HamanoApr 16, 2026
  8. Taylor BlauApr 16, 2026
  9. Derrick StoleeApr 19, 2026
  10. Junio C HamanoApr 20, 2026
  11. Taylor BlauApr 16, 2026
  12. Jeff KingApr 16, 2026
  13. Junio C HamanoApr 16, 2026
  14. Junio C HamanoApr 16, 2026
  15. Jeff KingApr 16, 2026
  16. Junio C HamanoApr 16, 2026
  17. Jeff KingApr 16, 2026
  18. Junio C HamanoApr 17, 2026
  19. MIDX: revert the default version to v1Junio C Hamano, Apr 16, 2026
  20. Junio C HamanoApr 16, 2026
  21. Junio C HamanoApr 16, 2026
  22. Taylor BlauApr 16, 2026
  23. Jeff KingApr 16, 2026
  24. Junio C HamanoApr 16, 2026
  25. Jeff KingApr 16, 2026
  26. Jeff KingApr 16, 2026
  27. Taylor BlauApr 16, 2026
  28. Jeff KingApr 16, 2026
  29. Junio C HamanoApr 17, 2026
  30. Elijah NewrenApr 17, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.