git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] MIDX: revert the default version to v1

From
Jeff King <peff@peff.net>
Date
Apr 16, 2026, 23:27 UTC
Message-ID
<20260416232755.GC1904316@coredump.intra.peff.net>
In-Reply-To
<aeFQvu4iqJAQMjCy@nand.local>
On Thu, Apr 16, 2026 at 05:12:30PM -0400, Taylor Blau wrote:
Show 8 quoted lines
> > As a result, writing a midx with Git 2.54-rc2 puts the repository into a
> > state that is unusable with Git 2.53. And this midx write may happen
> > behind the scenes as part of normal operations, like fetch.
> 
> I'm not sure if it's worth mentioning, but I think that it's reasonable
> to say "Git 2.53 and earlier", with the implied lower bound being which
> version first introduced the MIDX. I think it's equally fine as-is,
> though.

Yeah, that is a little more clear. Looks like it's been pushed out to next already, though.

Show 9 quoted lines
> > I have a feeling there are probably some gaps in v2 testing in t5319,
> > since we are no longer using v2 for the bulk of the tests. IMHO that is
> > OK to sort out post-release.
> 
> Perhaps, although you could make the opposite argument for v1 MIDXs
> when we previously switched the default to write v2 MIDXs. The format
> differs only in the version field, and the ordering constraints on the
> packs within the MIDX. That area and the compatibility issues here are
> the "interesting" parts to test IMHO.

I think that t5319 specifically writes a few midxs with v1 to test the ordering constraints. Probably there should now be some v2 specific tests in the same way. I was hoping you could pick up the pieces there, post-2.54.

-Peff
Previous: Taylor BlauNext: Junio C Hamano
Message 28 of 30 in “[ANNOUNCE] Git v2.54.0-rc2”
  1. Junio C HamanoApr 14, 2026
  2. MIDX woes, was Re: [ANNOUNCE] Git v2.54.0-rc2Johannes Schindelin, Apr 15, 2026
  3. Junio C HamanoApr 15, 2026
  4. Jeff KingApr 16, 2026
  5. Jeff KingApr 16, 2026
  6. Derrick StoleeApr 16, 2026
  7. Junio C HamanoApr 16, 2026
  8. Taylor BlauApr 16, 2026
  9. Derrick StoleeApr 19, 2026
  10. Junio C HamanoApr 20, 2026
  11. Taylor BlauApr 16, 2026
  12. Jeff KingApr 16, 2026
  13. Junio C HamanoApr 16, 2026
  14. Junio C HamanoApr 16, 2026
  15. Jeff KingApr 16, 2026
  16. Junio C HamanoApr 16, 2026
  17. Jeff KingApr 16, 2026
  18. Junio C HamanoApr 17, 2026
  19. MIDX: revert the default version to v1Junio C Hamano, Apr 16, 2026
  20. Junio C HamanoApr 16, 2026
  21. Junio C HamanoApr 16, 2026
  22. Taylor BlauApr 16, 2026
  23. Jeff KingApr 16, 2026
  24. Junio C HamanoApr 16, 2026
  25. Jeff KingApr 16, 2026
  26. Jeff KingApr 16, 2026
  27. Taylor BlauApr 16, 2026
  28. Jeff KingApr 16, 2026
  29. Junio C HamanoApr 17, 2026
  30. Elijah NewrenApr 17, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.