git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: MIDX woes, was Re: [ANNOUNCE] Git v2.54.0-rc2

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 16, 2026, 20:12 UTC
Message-ID
<xmqqqzoezmt9.fsf@gitster.g>
In-Reply-To
<20260416194922.GA1887222@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
> Yeah, I agree that re-wording would be a good idea here.
I actually no longer think so.
Show 9 quoted lines
> I think this
> can happen post-release. We'd like for this to have happened long ago,
> but it didn't. Doing it in 2.54 versus 2.55 does not really matter, as:
>
>   1. We still have to worry about 2.53 and earlier anyway, so one
>      version is not much in the grand scheme of things.
>
>   2. For midx v2, 2.54 knows how to read it anyway, so is not affected
>      by the problem. ;)
I agree 100% with this.

Looking at the later part of load_multi_pack_index_one() function, it is full of die() calls, not prepared to degrade gracefully at all.

The reason why I do not think reword is worth doing is that as far as this function (i.e., "Here is an MIDX file---please read it and give me struct multi_pack_index back") is concerned, these error returns are giving diagnosis on the nature of errors. Sometimes we cannot learn the length of the file, sometimes we find that the file is unreasonably short, sometimes it is not sorted properly, etc. None of the existing "error + cleanup" says "we are continuing anyway" and that is good. The decision to keep going without using midx file (or not) belongs to the caller, so if we wanted to say that, we should say so in the caller, not here.

Previous: Jeff KingNext: Jeff King
Message 16 of 30 in “[ANNOUNCE] Git v2.54.0-rc2”
  1. Junio C HamanoApr 14, 2026
  2. MIDX woes, was Re: [ANNOUNCE] Git v2.54.0-rc2Johannes Schindelin, Apr 15, 2026
  3. Junio C HamanoApr 15, 2026
  4. Jeff KingApr 16, 2026
  5. Jeff KingApr 16, 2026
  6. Derrick StoleeApr 16, 2026
  7. Junio C HamanoApr 16, 2026
  8. Taylor BlauApr 16, 2026
  9. Derrick StoleeApr 19, 2026
  10. Junio C HamanoApr 20, 2026
  11. Taylor BlauApr 16, 2026
  12. Jeff KingApr 16, 2026
  13. Junio C HamanoApr 16, 2026
  14. Junio C HamanoApr 16, 2026
  15. Jeff KingApr 16, 2026
  16. Junio C HamanoApr 16, 2026
  17. Jeff KingApr 16, 2026
  18. Junio C HamanoApr 17, 2026
  19. MIDX: revert the default version to v1Junio C Hamano, Apr 16, 2026
  20. Junio C HamanoApr 16, 2026
  21. Junio C HamanoApr 16, 2026
  22. Taylor BlauApr 16, 2026
  23. Jeff KingApr 16, 2026
  24. Junio C HamanoApr 16, 2026
  25. Jeff KingApr 16, 2026
  26. Jeff KingApr 16, 2026
  27. Taylor BlauApr 16, 2026
  28. Jeff KingApr 16, 2026
  29. Junio C HamanoApr 17, 2026
  30. Elijah NewrenApr 17, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.