git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] MIDX: revert the default version to v1

From
Jeff King <peff@peff.net>
Date
Apr 16, 2026, 23:26 UTC
Message-ID
<20260416232601.GA1904594@coredump.intra.peff.net>
In-Reply-To
<20260416232455.GB1904316@coredump.intra.peff.net>
On Thu, Apr 16, 2026 at 07:24:55PM -0400, Jeff King wrote:
Show 15 quoted lines
> > Just a sytle thing but I'd prefer to see this written like this:
> > 
> > +	ctx.version = ((opts->flags & MIDX_WRITE_COMPACT)
> > +		       ? MIDX_VERSION_V2
> > +		       : MIDX_VERSION_V1);
> > 
> > because you do not have to worry about the precedence between & and
> > ?: with an extra (parentheses), and a ternary split into multiple
> > lines is easier to spot if you write it at the beginning of the
> > line, with ?  and : aligned.
> 
> OK. I like the "?" at the end of the first line, since it makes it clear
> from just that line that it is a conditional and not a direct
> assignment. But I don't overly care, and if you want to mark it up as
> you apply (if it is not already too late), I am fine with that.
Ah, I just fetched next and saw that you did so already. Good. :)
-Peff
Previous: Jeff KingNext: Taylor Blau
Message 26 of 30 in “[ANNOUNCE] Git v2.54.0-rc2”
  1. Junio C HamanoApr 14, 2026
  2. MIDX woes, was Re: [ANNOUNCE] Git v2.54.0-rc2Johannes Schindelin, Apr 15, 2026
  3. Junio C HamanoApr 15, 2026
  4. Jeff KingApr 16, 2026
  5. Jeff KingApr 16, 2026
  6. Derrick StoleeApr 16, 2026
  7. Junio C HamanoApr 16, 2026
  8. Taylor BlauApr 16, 2026
  9. Derrick StoleeApr 19, 2026
  10. Junio C HamanoApr 20, 2026
  11. Taylor BlauApr 16, 2026
  12. Jeff KingApr 16, 2026
  13. Junio C HamanoApr 16, 2026
  14. Junio C HamanoApr 16, 2026
  15. Jeff KingApr 16, 2026
  16. Junio C HamanoApr 16, 2026
  17. Jeff KingApr 16, 2026
  18. Junio C HamanoApr 17, 2026
  19. MIDX: revert the default version to v1Junio C Hamano, Apr 16, 2026
  20. Junio C HamanoApr 16, 2026
  21. Junio C HamanoApr 16, 2026
  22. Taylor BlauApr 16, 2026
  23. Jeff KingApr 16, 2026
  24. Junio C HamanoApr 16, 2026
  25. Jeff KingApr 16, 2026
  26. Jeff KingApr 16, 2026
  27. Taylor BlauApr 16, 2026
  28. Jeff KingApr 16, 2026
  29. Junio C HamanoApr 17, 2026
  30. Elijah NewrenApr 17, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.