Re: [PATCH 4/4] core.abbrev: raise the default abbreviation to 12 hexdigits

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 30, 2016, 03:54 UTC
Message-ID: <xmqqtwcyavou.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CA+55aFyHn0Q-qPq4dPEJ7X_4jf5UbsVw2vE-4LoWYbPn6gS10g@mail.gmail.com>

Linus Torvalds <torvalds@linux-foundation.org> writes:

> So this patch may actually be "production ready" apart from the fact
> that some tests still fail (at least t2027-worktree-list.sh) because
> of different short SHA1 cases.

t2027 has at least two problems.

 * "git worktree" does not read the core.abbrev configuration,
   without a recent fix in jc/worktree-config, i.e. d49028e6
   ("worktree: honor configuration variables", 2016-09-26).

 * The script uses "git rev-parse --short HEAD"; I suspect that it
   says "ah, default_abbrev is -1 and minimum_abbrev is 4, so let's
   try abbreviating to 4 hexdigits".

The first failure in t3203 seems to come from the same issue in "rev-parse --short".