Re: [RFC/PATCH] core.abbrev doc: document and test the abbreviation length

From: Jeff King <peff@peff.net>
Date: Feb 4, 2019, 23:32 UTC
Message-ID: <20190204233235.GB2366@sigill.intra.peff.net>
In-Reply-To: <xmqq36p3uxq2.fsf@gitster-ct.c.googlers.com>

On Mon, Feb 04, 2019 at 12:04:21PM -0800, Junio C Hamano wrote:

Show 13 quoted lines

> Instead of exposing this pretty-much "test-only" feature as a new
> option to t/helper/test-tool, I think it is OK, if not even better,
> to have it in rev-parse proper like this patch does.
> 
> I however have a mildly strong suspition that people would expect
> "rev-parse --abbrev-len=<num>" to be a synonym of "--short=<num>"
> 
> As this is pretty-much a test-only option, perhaps going longer but
> more descriptive would make sense?  
> 
> 	git rev-parse --compute-abbrev-length-for <object-count>
> 
> may be an overkill, but something along those lines.

You could even default <object-count> to the number of objects in the repository. Which implies that perhaps the best spot is the command where we already count the number of objects, git-count-objects.

-Peff