Re: [PATCH 4/4] core.abbrev: raise the default abbreviation to 12 hexdigits

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Sep 30, 2016, 00:28 UTC
Message-ID: <CA+55aFyXxQSygO-gqevLZDjuggOaHs7HsRO=P6GhpC3GStqwvQ@mail.gmail.com>
In-Reply-To: <CA+55aFysvNc4p_nFcV=edctCizJBJtDjFOHJa-YYgVZQgBZfiA@mail.gmail.com>

On Thu, Sep 29, 2016 at 5:20 PM, Linus Torvalds <torvalds@linux-foundation.org> wrote:

>
> As you say, my original patch had neither of those issues.

To be fair, my original patch had a different worry that I didn't bother with: what if one of the _other_ callers of "get_short_sha1()" passed in -1 to it. I only handled the -1 case in th eone path care about in that first RFC for testing. So I'm *not* suggesting you should apply my first version,, It has issues too.

Let me see if I can massage my first hacky RFC test-patch into something more reliable.

              Linus

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.