Re: [PATCH 2/4] t13xx: do not assume system config is empty

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 29, 2016, 18:13 UTC
Message-ID: <xmqqintefuau.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20160929090108.hf2jzfcvbcsfaxw7@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 5 quoted lines

> I think anytime you would use GIT_CONFIG_NOSYSTEM over --local, it is an
> indication that the test is trying to check how multiple sources
> interact. And the right thing to do for them is to set GIT_ETC_GITCONFIG
> to some known quantity. We just couldn't do that before, so we skipped
> it.  IOW, something like the patch below (on top of yours).

OK, that way we can make sure that "multiple sources" operations do look at the system-wide stuff.

Show 5 quoted lines

> Note that the
> commands that are doing a "--get" and not a "--list" don't actually seem
> to need either (because they are getting the values out of the local
> file anyway), so we could drop the setting of GIT_ETC_GITCONFIG from
> them entirely.

"either" meaning "we do not need to add --local and we do not need GIT_CONFIG_NOSYSTEM"?