Re: [PATCH v2 1/1] status: do not get confused by submodules in excluded directories

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 26, 2017, 02:28 UTC
Message-ID: <xmqqtvymfxrj.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <33355d901d5f1c4d040b33bfd5b94e01803c03cd.1508964005.git.johannes.schindelin@gmx.de>

Johannes Schindelin <johannes.schindelin@gmx.de> writes:

Show 23 quoted lines

> We meticulously pass the `exclude` flag to the `treat_directory()`
> function so that we can indicate that files in it are excluded rather
> than untracked when recursing.
>
> But we did not yet treat submodules the same way.
>
> Because of that, `git status --ignored --untracked` with a submodule
> `submodule` in a gitignored `tracked/` would show the submodule in the
> "Untracked files" section, e.g.
>
> 	On branch master
> 	Untracked files:
> 	  (use "git add <file>..." to include in what will be committed)
>
> 		tracked/submodule/
>
> 	Ignored files:
> 	  (use "git add -f <file>..." to include in what will be committed)
>
> 		tracked/submodule/initial.t
>
> Instead, we would want it to show the submodule in the "Ignored files"
> section:

Makes sense. Also listing the paths in the embedded working tree like initial.t as if it were part of our project is utterly wrong, especially because we are not doing any --recurse-submodules thing.

Both the change and the updated description looks good.  Thanks.