git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] status: do not get confused by submodules in excluded directories

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 24, 2017, 05:18 UTC
Message-ID
<xmqqo9oxkts6.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<244d71f47336e985ae265573b7d523cd8b3943bd.1508244305.git.johannes.schindelin@gmx.de>
Johannes Schindelin <johannes.schindelin@gmx.de> writes:
Show 5 quoted lines
> We meticulously pass the `exclude` flag to the `treat_directory()`
> function so that we can indicate that files in it are excluded rather
> than untracked when recursing.
>
> But we did not yet treat submodules the same way.

... "because of that, we ended up showing <<what incorrect result in what situation>>" would be a nice thing to have here, so that it can be copied to the release notes for the bugfix.

How far back a release do we want to make this fix applicable? It seems that it applies cleanly to maint-2.13 without breaking from my quick test, so that is probably where I'll queue this, even though we may no longer issue further maintenance releases on that track.

Any comment from submodule folks?

Sorry that I didn't notice this was left unattended by anybody til now. Will queue while waiting for those who are into submodules to respond.

Thanks.
Previous: Johannes SchindelinNext: Heiko Voigt
Message 2 of 12 in “status: do not get confused by submodules in excluded directories”
  1. status: do not get confused by submodules in excluded directoriesJohannes Schindelin, Oct 17, 2017
  2. Junio C HamanoOct 24, 2017
  3. Heiko VoigtOct 24, 2017
  4. Stefan BellerOct 24, 2017
  5. Junio C HamanoOct 25, 2017
  6. Heiko VoigtOct 25, 2017
  7. Johannes SchindelinOct 25, 2017
  8. Kevin DaudtOct 24, 2017
  9. Johannes SchindelinOct 25, 2017
  10. 0/1 Do not handle submodules in excluded directories as untrackedJohannes Schindelin, Oct 25, 2017
  11. 1/1 status: do not get confused by submodules in excluded directoriesJohannes Schindelin, Oct 25, 2017
  12. Junio C HamanoOct 26, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.