git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] status: do not get confused by submodules in excluded directories

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Oct 25, 2017, 20:39 UTC
Message-ID
<alpine.DEB.2.21.1.1710252238390.6482@virtualbox>
In-Reply-To
<20171025140414.GA1368@book.hvoigt.net>
Hi,
On Wed, 25 Oct 2017, Heiko Voigt wrote:
Show 29 quoted lines
> On Wed, Oct 25, 2017 at 10:28:25AM +0900, Junio C Hamano wrote:
> > Heiko Voigt <hvoigt@hvoigt.net> writes:
> > 
> > > On Tue, Oct 24, 2017 at 02:18:49PM +0900, Junio C Hamano wrote:
> > >> Johannes Schindelin <johannes.schindelin@gmx.de> writes:
> > >> 
> > >> > We meticulously pass the `exclude` flag to the `treat_directory()`
> > >> > function so that we can indicate that files in it are excluded rather
> > >> > than untracked when recursing.
> > >> >
> > >> > But we did not yet treat submodules the same way.
> > >> 
> > >> ... "because of that, we ended up showing <<what incorrect result in
> > >> what situation>>" would be a nice thing to have here, so that it can
> > >> be copied to the release notes for the bugfix.  
> > >
> > > Yes I agree that would be nice here. It was not immediately obvious that
> > > this only applies when using both flags: -u and --ignored.
> > 
> > Does any of you care to fill in the <<blanks above>> then? ;-)
> 
> How about:
> 
> Because of that, we ended up showing the submodule as untracked and its
> content as ignored files when using the --ignored and -u flags with git
> status.
> 
> ? But maybe Dscho also has some more information to add about his
> situation?

He has... as part of v2, a substantially more detailed commit message will reach your inbox Real Soon Now.

Ciao, Dscho

Previous: Heiko VoigtNext: Kevin Daudt
Message 7 of 12 in “status: do not get confused by submodules in excluded directories”
  1. status: do not get confused by submodules in excluded directoriesJohannes Schindelin, Oct 17, 2017
  2. Junio C HamanoOct 24, 2017
  3. Heiko VoigtOct 24, 2017
  4. Stefan BellerOct 24, 2017
  5. Junio C HamanoOct 25, 2017
  6. Heiko VoigtOct 25, 2017
  7. Johannes SchindelinOct 25, 2017
  8. Kevin DaudtOct 24, 2017
  9. Johannes SchindelinOct 25, 2017
  10. 0/1 Do not handle submodules in excluded directories as untrackedJohannes Schindelin, Oct 25, 2017
  11. 1/1 status: do not get confused by submodules in excluded directoriesJohannes Schindelin, Oct 25, 2017
  12. Junio C HamanoOct 26, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.