Re: [PATCH] status: do not get confused by submodules in excluded directories

From: Heiko Voigt <hvoigt@hvoigt.net>
Date: Oct 24, 2017, 12:15 UTC
Message-ID: <20171024121536.GA88363@book.hvoigt.net>
In-Reply-To: <xmqqo9oxkts6.fsf@gitster.mtv.corp.google.com>

On Tue, Oct 24, 2017 at 02:18:49PM +0900, Junio C Hamano wrote:

Show 11 quoted lines

> Johannes Schindelin <johannes.schindelin@gmx.de> writes:
> 
> > We meticulously pass the `exclude` flag to the `treat_directory()`
> > function so that we can indicate that files in it are excluded rather
> > than untracked when recursing.
> >
> > But we did not yet treat submodules the same way.
> 
> ... "because of that, we ended up showing <<what incorrect result in
> what situation>>" would be a nice thing to have here, so that it can
> be copied to the release notes for the bugfix.

Yes I agree that would be nice here. It was not immediately obvious that this only applies when using both flags: -u and --ignored.

Seems to be a corner that not many people are using. At first I thought a plain 'git status' would show that behavior...

Show 10 quoted lines

> How far back a release do we want to make this fix applicable?  It
> seems that it applies cleanly to maint-2.13 without breaking from my
> quick test, so that is probably where I'll queue this, even though
> we may no longer issue further maintenance releases on that track.
> 
> Any comment from submodule folks?
> 
> Sorry that I didn't notice this was left unattended by anybody til
> now.  Will queue while waiting for those who are into submodules to
> respond.

Looks good to me.

Cheers Heiko