Re: [PATCH] status: do not get confused by submodules in excluded directories

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 25, 2017, 01:28 UTC
Message-ID: <xmqqh8uoj9s6.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20171024121536.GA88363@book.hvoigt.net>

Heiko Voigt <hvoigt@hvoigt.net> writes:

Show 15 quoted lines

> On Tue, Oct 24, 2017 at 02:18:49PM +0900, Junio C Hamano wrote:
>> Johannes Schindelin <johannes.schindelin@gmx.de> writes:
>> 
>> > We meticulously pass the `exclude` flag to the `treat_directory()`
>> > function so that we can indicate that files in it are excluded rather
>> > than untracked when recursing.
>> >
>> > But we did not yet treat submodules the same way.
>> 
>> ... "because of that, we ended up showing <<what incorrect result in
>> what situation>>" would be a nice thing to have here, so that it can
>> be copied to the release notes for the bugfix.  
>
> Yes I agree that would be nice here. It was not immediately obvious that
> this only applies when using both flags: -u and --ignored.

Does any of you care to fill in the <<blanks above>> then? ;-)

> Looks good to me.
>
> Cheers Heiko