Re: [PATCH] status: do not get confused by submodules in excluded directories

From: Heiko Voigt <hvoigt@hvoigt.net>
Date: Oct 25, 2017, 14:04 UTC
Message-ID: <20171025140414.GA1368@book.hvoigt.net>
In-Reply-To: <xmqqh8uoj9s6.fsf@gitster.mtv.corp.google.com>

On Wed, Oct 25, 2017 at 10:28:25AM +0900, Junio C Hamano wrote:

Show 19 quoted lines

> Heiko Voigt <hvoigt@hvoigt.net> writes:
> 
> > On Tue, Oct 24, 2017 at 02:18:49PM +0900, Junio C Hamano wrote:
> >> Johannes Schindelin <johannes.schindelin@gmx.de> writes:
> >> 
> >> > We meticulously pass the `exclude` flag to the `treat_directory()`
> >> > function so that we can indicate that files in it are excluded rather
> >> > than untracked when recursing.
> >> >
> >> > But we did not yet treat submodules the same way.
> >> 
> >> ... "because of that, we ended up showing <<what incorrect result in
> >> what situation>>" would be a nice thing to have here, so that it can
> >> be copied to the release notes for the bugfix.  
> >
> > Yes I agree that would be nice here. It was not immediately obvious that
> > this only applies when using both flags: -u and --ignored.
> 
> Does any of you care to fill in the <<blanks above>> then? ;-)

How about:

Because of that, we ended up showing the submodule as untracked and its content as ignored files when using the --ignored and -u flags with git status.

? But maybe Dscho also has some more information to add about his situation?

Cheers Heiko