Re: [PATCH v8 07/15] bugreport: add git-remote-https version

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 25, 2020, 22:26 UTC
Message-ID: <xmqqtv3el2w5.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20200225220838.GB212281@google.com>

Emily Shaffer <emilyshaffer@google.com> writes:

Show 5 quoted lines

> How about if I localize the bugreport template, headers, and formatted
> comments (e.g. "3745 local loose objects"), and include a tip in 'git
> help bugreport' suggesting that if it doesn't look right, maybe the user
> wants to run it with 'LANG= LANGUAGE= git bugreport' to ensure it
> actually gets generated?

I think that will be what is going to happen anyway in the real world. We'd spend a reasonable effort for localization (and I personally am perfectly OK if the effort for the initial round is "almost zero"), but make sure C-locale is left as an escape hatch.

> I had another thought, actually, that this is maybe semantically similar
> problem to the malformed config we discussed earlier in the review. Does
> it make sense to include some kind of --safemode flag to 'git' which
> asks it to not perform localization and not read configs?

I suspect that "git --safemode" would always end up being buggy than running "git" under LANG=C LC_ALL=C GIT_CONFIG=/dev/null or something like that ;-)

Wouldn't it defeat more than 30% of the value of the tool if we do not read and report the contents of the configuration file(s)?