Re: [PATCH v9 2/5] bugreport: add tool to generate debugging info

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 20, 2020, 00:28 UTC
Message-ID: <xmqqd097dg4k.fsf@gitster.c.googlers.com>
In-Reply-To: <20200319213902.GB45325@google.com>

Emily Shaffer <emilyshaffer@google.com> writes:

Show 8 quoted lines

> Builtin:
> + Don't have to call out-of-process to identify 'git version --build-options'
> + Better assurance that we aren't shipping a broken bugreport alongside a new
>   version
> - Binary bloat, possible startup time hit
> ? Libraries will behave identically to where the user is seeing issues
>   (This point is a possible pro but also a possible con; see similar point in
>   standalone list)

 - Makes it hard to pull in libraries that "bugreport" alone will
   want to use in the future without negatively impacting the rest
   of Git.

>  - Time to editor for 'git bugreport' with the same setup as previous

This is something we absolutely should totally ignore. Even if the bulitin version takes 1 sec to spawn an editor while a standalone one took only 0.1 sec, if other criteria you listed that are more important favours the builtin solution, we should pick it.

In any case, I think we've wasted enough time on this. Let's see a minimum working version that won't break/affect the rest of Git and ship it standalone.

Thanks.