Re: [PATCH v9 2/5] bugreport: add tool to generate debugging info

From: Jeff Hostetler <git@jeffhostetler.com>
Date: Mar 5, 2020, 23:34 UTC
Message-ID: <5aae34d7-ed76-0e71-d0c4-959deeb1b2ca@jeffhostetler.com>
In-Reply-To: <nycvar.QRO.7.76.6.2003042232340.46@tvgsbejvaqbjf.bet>

On 3/4/2020 4:35 PM, Johannes Schindelin wrote:

Show 25 quoted lines

> Hi,
> 
> On Mon, 2 Mar 2020, Emily Shaffer wrote:
> 
>>   .gitignore                      |   1 +
>>   Documentation/git-bugreport.txt |  46 ++++++++++++++
>>   Makefile                        |   5 ++
>>   bugreport.c                     | 105 ++++++++++++++++++++++++++++++++
>>   command-list.txt                |   1 +
>>   strbuf.c                        |   4 ++
>>   strbuf.h                        |   1 +
>>   t/t0091-bugreport.sh            |  61 +++++++++++++++++++
>>   8 files changed, 224 insertions(+)
>>   create mode 100644 Documentation/git-bugreport.txt
>>   create mode 100644 bugreport.c
>>   create mode 100755 t/t0091-bugreport.sh
> 
> Hmm. I am still _quite_ convinced that this would be much better as a
> built-in. Remember, non-built-ins come with a footprint, and I do not
> necessarily think that you will want to spend 3MB on a `git-bugreport`
> executable when you could have it for a couple dozen kilobytes inside
> `git` instead.
> 
> Ciao,
> Dscho

Having this command be a stand-alone exe rather than a builtin allows it to have a different linkage. For example, you could include the libcurl and other libraries that are only linked into the transports. And then report version numbers for them if you wanted.

Jeff