Re: [PATCH v9 2/5] bugreport: add tool to generate debugging info
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Mar 20, 2020, 15:35 UTC
- Message-ID
- <nycvar.QRO.7.76.6.2003201633560.46@tvgsbejvaqbjf.bet>
- In-Reply-To
- <xmqqd097dg4k.fsf@gitster.c.googlers.com>
On Thu, 19 Mar 2020, Junio C Hamano wrote:
Show 14 quoted lines
> Emily Shaffer <emilyshaffer@google.com> writes: > > > Builtin: > > + Don't have to call out-of-process to identify 'git version --build-options' > > + Better assurance that we aren't shipping a broken bugreport alongside a new > > version > > - Binary bloat, possible startup time hit > > ? Libraries will behave identically to where the user is seeing issues > > (This point is a possible pro but also a possible con; see similar point in > > standalone list) > > - Makes it hard to pull in libraries that "bugreport" alone will > want to use in the future without negatively impacting the rest > of Git.
And of course we should never do that, lest `git bugreport` won't even load because of it while `git` would.
So even in the purely speculative scenario that we _wanted_ to add more libraries (which we don't, why should we?), we wouldn't actually do it.
Show 10 quoted lines
> > - Time to editor for 'git bugreport' with the same setup as previous > > This is something we absolutely should totally ignore. Even if the > bulitin version takes 1 sec to spawn an editor while a standalone > one took only 0.1 sec, if other criteria you listed that are more > important favours the builtin solution, we should pick it. > > In any case, I think we've wasted enough time on this. Let's see a > minimum working version that won't break/affect the rest of Git and > ship it standalone.
I still disagree with that, but it seems that no amount of arguments will convince Junio, and he's dead set on the standalone version.