[PATCH v9 0/5] add git-bugreport tool
- From
Emily Shaffer <emilyshaffer@google.com>
- Date
- Mar 2, 2020, 23:03 UTC
- Message-ID
- <20200302230400.107428-1-emilyshaffer@google.com>
- In-Reply-To
- <20200220015858.181086-1-emilyshaffer@google.com>
I did run this set through the Azure Pipelines CI [2] and hope that means it's platform-safe; if that's not the case, please let me know your concerns.
For the relevant patches, I made the following changes since v8:
- More portable strftime format - Use open() instead of fopen_for_writing() in order to specify O_CREAT | O_EXCL | O_WRONLY. - Fix a use-after-free. - Add i18n/l10n macro all over the place; per [3] let's translate the whole contents of the report, because it's easy to force to a different language and we may not be the only ones reading reports - Use a lot less strbuf_complete_line() - when we're making library calls, we have control over the format, so we do know whether it ends in \n or not; let's not waste the time checking it. - Minor nit on uname header phrasing - Reword the structure of compat/compiler.h to separate libc and compiler. - Add MSVC reporting in compat/compiler.h (thanks Dscho).
Thanks all. - Emily
[1]: https://lore.kernel.org/git/20200225235558.GG212281@google.com [2]: https://github.com/gitgitgadget/git/pull/566 [3]: https://lore.kernel.org/git/xmqqimjukzzv.fsf@gitster-ct.c.googlers.com
Emily Shaffer (5):
help: move list_config_help to builtin/help
Note that this patch is still required for this series because the
help library (for version/build info) is unusable without it.
bugreport: add tool to generate debugging info
bugreport: gather git version and build info
bugreport: add uname info
bugreport: add compiler info.gitignore | 2 + Documentation/git-bugreport.txt | 52 ++++++++++++ Makefile | 18 +++- bugreport.c | 142 ++++++++++++++++++++++++++++++++ builtin/help.c | 86 +++++++++++++++++++ command-list.txt | 1 + compat/compiler.h | 38 +++++++++ generate-cmdlist.sh | 19 ----- generate-configlist.sh | 21 +++++ help.c | 131 +++++++---------------------- help.h | 2 +- strbuf.c | 4 + strbuf.h | 1 + t/t0091-bugreport.sh | 61 ++++++++++++++ 14 files changed, 452 insertions(+), 126 deletions(-) create mode 100644 Documentation/git-bugreport.txt create mode 100644 bugreport.c create mode 100644 compat/compiler.h create mode 100755 generate-configlist.sh create mode 100755 t/t0091-bugreport.sh
-- 2.25.0.265.gbab2e86ba0-goog