Re: [PATCH v2 2/2] blame: ignore revs in HEAD:.git-blame-ignore-revs
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Oct 11, 2026, 18:58 UTC
- Message-ID
- <xmqqtsmsdpxz.fsf@gitster.g>
- In-Reply-To
- <35e303d65bc378e733b1e9e8d6908a829352e857.1791493644.git.gitgitgadget@gmail.com>
"Ravi Mistry via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 27 quoted lines
> +static void parse_default_ignore_revs_blob(struct blame_scoreboard *sb,
> + const char *name)
> +{
> + struct object_context oc;
> + struct object_id oid;
> + enum object_type type;
> + size_t size;
> + char *buf;
> +
> + if (get_oid_with_context(the_repository, name, GET_OID_QUIETLY,
> + &oid, &oc))
> + goto out;
> + if (!S_ISREG(oc.mode))
> + goto out;
> +
> + buf = odb_read_object(the_repository->objects, &oid, &type, &size);
> + if (!buf)
> + goto out;
> + if (type == OBJ_BLOB)
> + oidset_parse_buffer_carefully(&sb->ignore_list, buf, size,
> + the_repository->hash_algo,
> + peel_to_commit_oid, sb);
> + free(buf);
> +
> +out:
> + object_context_release(&oc);
> +}Since the scoreboard is passed around throughout the subsystem and has a pointer to the repository it is working with, a new function like this one does not have to add new references to the_repository.
I do not think it is ultra urgent, but I suspect that many of existing references in this file to the_repository happen in functions that take the scoreboard pointer, and they should be able to replace the_repository with sb->repo more or less mechanically.