Re: [PATCH v5 0/2] blame: ignore revs in .git-blame-ignore-revs by default
On 13/10/2026 21:39, Junio C Hamano wrote:
Show 11 quoted lines
> Ravi Mistry <rmistry@google.com> writes:
> >> In v6, build_ignorelist() passes i->string to
>> parse_default_ignore_revs() so the string is actually used (both for
>> the working-tree path and for "HEAD:<path>" in bare repositories), and
>> cmd_blame() sets ->util = (void *)1 with an explanatory comment (rather
>> than passing the scoreboard).
> > Very cleanly done. I very much like this new design that still
> honors what the item->string says, instead of "ah, .util is not
> NULL, so let's do the hardcoded default thing".
> > Unless I hear objections in a few days, let's mark the topic ready
> for 'next'.
I'm not sure we need the lstat() call before open_nofollow() in the second patch of V6 but everything else looked good - I'd be happy to see that version merged.
Thanks
Phillip