git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 2/2] blame: ignore revs in HEAD:.git-blame-ignore-revs

From
RMRavi Mistry <rmistry@google.com>
Date
Oct 12, 2026, 19:21 UTC
Message-ID
<20261012192157.1835972-1-rmistry@google.com>
In-Reply-To
<xmqqbj8yan77.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> writes:
Show 14 quoted lines
> Phillip Wood <phillip.wood123@gmail.com> writes:
>
> > I've left a couple of comments on v3. Ignoring uncommitted changes in
> > the file in the working tree seems a bit odd to me and we seem to be
> > prepared to load a file of any size from an untrusted source.
>
> The latter sounds like a sensible thing to worry about.  Thanks for
> bringing it up.
>
> I do not have strong opinions either way on the former myself (the
> behaviour implemented is to attempt matching what the hosting sites
> do, which obviously work from the committed copy).  It indeed feels
> more intuitive if the checked out copy (or even the file before it
> gets added for the first time) were consulted.

I have sent v4, which caps the size of the default HEAD:.git-blame-ignore-revs blob at 100MB (matching ATTR_MAX_FILE_SIZE from 3c50032ff5 ("attr: ignore overly large gitattributes files", 2022-12-01)) so an oversized blob is skipped with a warning without being loaded into memory.

For v4, I left the behavior as reading from HEAD:.git-blame-ignore-revs to match hosting sites for now. Maybe consulting the working tree could be explored in the future in a separate series if desired, or please let me know if you or Phillip would prefer to change it in this series.

Thanks!
Previous: Junio C HamanoNext: Junio C Hamano
Message 20 of 40 in “blame: default to ignoring revisions in .git-blame-ignore-revs”
  1. blame: default to ignoring revisions in .git-blame-ignore-revsRavi Mistry via GitGitGadget, Sep 11, 2026
  2. Ravi MistrySep 30, 2026
  3. Junio C HamanoOct 5, 2026
  4. Ravi MistryOct 5, 2026
  5. Junio C HamanoOct 7, 2026
  6. Ravi MistryOct 7, 2026
  7. 0/2 blame: ignore revs in HEAD:.git-blame-ignore-revs by defaultRavi Mistry via GitGitGadget, Oct 8, 2026
  8. 1/2 blame: harden ignore-revs parser and tag peelingRavi Mistry via GitGitGadget, Oct 8, 2026
  9. Junio C HamanoOct 9, 2026
  10. Ravi MistryOct 10, 2026
  11. 2/2 blame: ignore revs in HEAD:.git-blame-ignore-revsRavi Mistry via GitGitGadget, Oct 8, 2026
  12. Junio C HamanoOct 9, 2026
  13. Eric SunshineOct 10, 2026
  14. Ravi MistryOct 10, 2026
  15. Junio C HamanoOct 11, 2026
  16. Ravi MistryOct 11, 2026
  17. Junio C HamanoOct 11, 2026
  18. Phillip WoodOct 12, 2026
  19. Junio C HamanoOct 12, 2026
  20. Ravi MistryOct 12, 2026
  21. Junio C HamanoOct 12, 2026
  22. Ravi MistryOct 13, 2026
  23. 0/2 blame: ignore revs in HEAD:.git-blame-ignore-revs by defaultRavi Mistry via GitGitGadget, Oct 11, 2026
  24. 1/2 blame: harden ignore-revs parser and tag peelingRavi Mistry via GitGitGadget, Oct 11, 2026
  25. 2/2 blame: ignore revs in HEAD:.git-blame-ignore-revsRavi Mistry via GitGitGadget, Oct 11, 2026
  26. Phillip WoodOct 12, 2026
  27. Ravi MistryOct 12, 2026
  28. 0/2 blame: ignore revs in HEAD:.git-blame-ignore-revs by defaultRavi Mistry via GitGitGadget, Oct 12, 2026
  29. 1/2 blame: harden ignore-revs parser and tag peelingRavi Mistry via GitGitGadget, Oct 12, 2026
  30. 2/2 blame: ignore revs in HEAD:.git-blame-ignore-revsRavi Mistry via GitGitGadget, Oct 12, 2026
  31. 0/2 blame: ignore revs in .git-blame-ignore-revs by defaultRavi Mistry via GitGitGadget, Oct 13, 2026
  32. 1/2 blame: harden ignore-revs parser and tag peelingRavi Mistry via GitGitGadget, Oct 13, 2026
  33. 2/2 blame: ignore revs in .git-blame-ignore-revs by defaultRavi Mistry via GitGitGadget, Oct 13, 2026
  34. Junio C HamanoOct 13, 2026
  35. Ravi MistryOct 13, 2026
  36. Junio C HamanoOct 13, 2026
  37. Phillip WoodOct 15, 2026
  38. 0/2 blame: ignore revs in .git-blame-ignore-revs by defaultRavi Mistry via GitGitGadget, Oct 13, 2026
  39. 1/2 blame: harden ignore-revs parser and tag peelingRavi Mistry via GitGitGadget, Oct 13, 2026
  40. 2/2 blame: ignore revs in .git-blame-ignore-revs by defaultRavi Mistry via GitGitGadget, Oct 13, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.