Re: [PATCH v2 2/2] blame: ignore revs in HEAD:.git-blame-ignore-revs
- From
- Ravi Mistry <rmistry@google.com>
- Date
- Oct 13, 2026, 14:48 UTC
- Message-ID
- <20261013144852.1155285-1-rmistry@google.com>
- In-Reply-To
- <xmqqwlrm4o6z.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> writes:
Show 10 quoted lines
> Ravi Mistry <rmistry@google.com> writes: > > For v4, I left the behavior as reading from HEAD:.git-blame-ignore-revs > > to match hosting sites for now. Maybe consulting the working tree could > > be explored in the future in a separate series if desired, or please let > > me know if you or Phillip would prefer to change it in this series. > > It needs to be justified in some way other than "match what the > forges do (which is to use the one from HEAD)", but other than that, > I think it would be more ergonomic to pick up the copy from the > working tree (with local modifications) in non-bare case.
Makes sense, I did not have a justification for sticking with HEAD other than matching hosting sites.
I have sent v5, which reads .git-blame-ignore-revs from the root of the working tree in non-bare repositories (and HEAD:.git-blame-ignore-revs in bare repositories) and updates the commit message to justify the behavior on ergonomic grounds.
Thanks!