Re: [PATCH v5 0/2] blame: ignore revs in .git-blame-ignore-revs by default
- From
- Ravi Mistry <rmistry@google.com>
- Date
- Oct 13, 2026, 20:24 UTC
- Message-ID
- <20261013202448.2116038-1-rmistry@google.com>
- In-Reply-To
- <xmqq4iepzex9.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> writes:
> > ++ config option. An empty file name, `""`, or `--no-ignore-revs-file` will > > That's "a configuration variable".
Fixed in Documentation/blame-options.adoc and in the commit log message.
Show 5 quoted lines
> Hmph, build_ignorelist() ignores the string and only pays attention > to the fact that the string_list_item having a non-null .util member, > so this diff, and the fact that a specific string is on the list, is > a bit misleading in two ways (i.e., the string itself does not > matter, and the value of .util member does not metter, either).
...
Show 12 quoted lines
> It probably deserves a comment to help future readers, e.g. > > /* > * An entry with non-NULL .util member adds the > * .git-blame-ignore-revs at the project root; > * see build_ignorelist() > */ > string_list_append(&ignore_revs_file_list, > ".git-blame-ignore-revs")->util = &sb; > > or something? It is especially misleading to pass &sb here because > it is not used as a scoreboard at all anywhere.
In v6, build_ignorelist() passes i->string to parse_default_ignore_revs() so the string is actually used (both for the working-tree path and for "HEAD:<path>" in bare repositories), and cmd_blame() sets ->util = (void *)1 with an explanatory comment (rather than passing the scoreboard).
Thanks!