Re: [PATCH v2 2/2] blame: ignore revs in HEAD:.git-blame-ignore-revs

From: Ravi Mistry <rmistry@google.com>
Date: Oct 10, 2026, 18:40 UTC
Message-ID: <20261010184007.112258-1-rmistry@google.com>
In-Reply-To: <xmqqbj92ochm.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

> These Helped-by: drew my attention as none of these folks commented
> on v1 of this series.  I do see they have helped the original series
> <pull.1809.v2.git.1728707867.gitgitgadget@gmail.com>, but it is not
> clear how much their inputs have survivied to this version.

From that earlier thread, Phillip suggested explaining why commit ae3f36dea1 originally avoided a default file, Kristoffer suggested the config override model and documenting --no-ignore-revs-file, and as Eric noted, his comments were minor structural suggestions such as updating the docs and placing the tests in t8013.

Show 10 quoted lines

> > +	while (!strbuf_getline(&sb, fp))
> > +		parse_oidset_line(set, &sb, algop, fn, cbdata);
> >  	if (ferror(fp))
> >  		die_errno("Could not read '%s'", path);
> >  	fclose(fp);
> >  	strbuf_release(&sb);
> >  }
>
> Shouldn't the above refactoring have been part of the previous step
> instead?

I extracted parse_oidset_line() in patch 2/2 because that is where the second caller (oidset_parse_buffer_carefully()) was added, though extracting it in patch 1/2 would avoid touching that loop in both patches. Happy to move this into patch 1/2 if preferred.

Thanks!