git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/5] activate diff.renames by default

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 23, 2016, 21:40 UTC
Message-ID
<xmqqsi0jxfz8.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<vpqsi0jf94g.fsf@anie.imag.fr>
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
Show 25 quoted lines
> Junio C Hamano <gitster@pobox.com> writes:
>
>> Matthieu Moy <Matthieu.Moy@imag.fr> writes:
>>
>>> I have always wondered why diff.renames was not activated by default.
>>> I've had it to true in my configuration for 9 years, and I've been
>>> teaching newbies to set it for a while without issue. I think it's
>>> time to activate it by default, but please let me know if I missed a
>>> reason to keep it to false.
>>>
>>> In any case, the first 3 patches are useful cleanups.
>>
>> It's a long time coming since I heard "I love how I can just say
>> 'oh, keep in mind that we might want to..' and 24 hours later you
>> did it." [*1*]
>>
>> I can hardly be an impartial judge for this series, though.
>>
>> [Reference]
>>
>> *1* http://thread.gmane.org/gmane.comp.version-control.git/3541/focus=3702
>
> I guess there's another reference needed to fully understand your
> message, and I'm not sure I have it right. Are you refering to the
> "merge-recursive: test rename threshold option" discussion?
Not at all.

I was just mentioning that it would at last be a major achievement, if this can safely turned on by default for everybody, after having invented the machinery and the feature looooong time ago ;-)

Previous: Matthieu MoyNext: Matthieu Moy
Message 18 of 29 in “activate diff.renames by default”
  1. 0/5 activate diff.renames by defaultMatthieu Moy, Feb 23, 2016
  2. 1/5 Documentation/diff-config: fix description of diff.renamesMatthieu Moy, Feb 23, 2016
  3. Jeff KingFeb 24, 2016
  4. Felipe Gonçalves AssisFeb 25, 2016
  5. Matthieu MoyFeb 25, 2016
  6. 2/5 t4001-diff-rename: wrap file creations in a testMatthieu Moy, Feb 23, 2016
  7. Jeff KingFeb 24, 2016
  8. Matthieu MoyFeb 24, 2016
  9. 3/5 t: add tests for diff.renames (true/false/unset)Matthieu Moy, Feb 23, 2016
  10. 4/5 log: introduce init_log_defaults()Matthieu Moy, Feb 23, 2016
  11. 5/5 diff: activate diff.renames by defaultMatthieu Moy, Feb 23, 2016
  12. Junio C HamanoFeb 23, 2016
  13. Matthieu MoyFeb 23, 2016
  14. Jeff KingFeb 24, 2016
  15. Matthieu MoyFeb 25, 2016
  16. Junio C HamanoFeb 23, 2016
  17. Matthieu MoyFeb 23, 2016
  18. Junio C HamanoFeb 23, 2016
  19. 0/5 activate diff.renames by defaultMatthieu Moy, Feb 25, 2016
  20. 1/5 Documentation/diff-config: fix description of diff.renamesMatthieu Moy, Feb 25, 2016
  21. Documentation/diff-config: fix description of diff.renamesMatthieu Moy, Feb 25, 2016
  22. Junio C HamanoFeb 25, 2016
  23. Junio C HamanoFeb 25, 2016
  24. 2/5 t4001-diff-rename: wrap file creations in a testMatthieu Moy, Feb 25, 2016
  25. 3/5 t: add tests for diff.renames (true/false/unset)Matthieu Moy, Feb 25, 2016
  26. 4/5 log: introduce init_log_defaults()Matthieu Moy, Feb 25, 2016
  27. Junio C HamanoFeb 25, 2016
  28. 5/5 diff: activate diff.renames by defaultMatthieu Moy, Feb 25, 2016
  29. Junio C HamanoFeb 25, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.