Re: [PATCH v2 1/5] Documentation/diff-config: fix description of diff.renames
Matthieu Moy <Matthieu.Moy@imag.fr> writes:
Show 24 quoted lines
> The description was misleading, since "set to any boolean value" include
> "set to false", and diff.renames=false does not enable basic detection,
> but actually disables it. Also, document that diff.renames only affects
> Porcelain.
>
> Signed-off-by: Matthieu Moy <Matthieu.Moy@imag.fr>
> ---
> Documentation/diff-config.txt | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/diff-config.txt b/Documentation/diff-config.txt
> index 6eaa452..40e5de9 100644
> --- a/Documentation/diff-config.txt
> +++ b/Documentation/diff-config.txt
> @@ -108,9 +108,13 @@ diff.renameLimit::
> detection; equivalent to the 'git diff' option '-l'.
>
> diff.renames::
> - Tells Git to detect renames. If set to any boolean value, it
> - will enable basic rename detection. If set to "copies" or
> - "copy", it will detect copies, as well.
> + Whether and how Git detects renames. If set to "false",
> + rename detection is disabled. If set to "true", basic rename
> + detection is enable. If set to "copies" or "copy", Git will
Ahh, I earlier said "Not a new issue", but it is introduced here ;-)
I'll patch them up. Thanks.
Show 7 quoted lines
> + detect copies, as well. Defaults to false. Note that this
> + affects only 'git diff' Porcelain like linkgit:git-diff[1] and
> + linkgit:git-log[1], and not lower level commands such as
> + linkgit:git-diff-files[1].
>
> diff.suppressBlankEmpty::
> A boolean to inhibit the standard behavior of printing a space
Junio C Hamano <gitster@pobox.com>