Re: [PATCH 5/5] diff: activate diff.renames by default

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Feb 25, 2016, 08:54 UTC
Message-ID: <vpqwppt5fwr.fsf@anie.imag.fr>
In-Reply-To: <20160224104203.GD21152@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 17 quoted lines

> On Tue, Feb 23, 2016 at 06:44:58PM +0100, Matthieu Moy wrote:
>
>> diff --git a/Documentation/diff-config.txt b/Documentation/diff-config.txt
>> index 1acd203..fdf5a79 100644
>> --- a/Documentation/diff-config.txt
>> +++ b/Documentation/diff-config.txt
>> @@ -111,7 +111,7 @@ diff.renames::
>>  	Whether and how Git detects renames.  If set to "false",
>>  	rename detection is disabled. If set to "true", basic rename
>>  	detection is enable.  If set to "copies" or "copy", Git will
>> -	detect copies, as well.  Defaults to false.
>> +	detect copies, as well.  Defaults to true.
>
> I wonder if we need to talk about plumbing versus porcelain here, as it
> does not default to true for diff-tree, for example. But I guess that is
> already the case (even setting it to true yourself does not affect
> diff-tree).

Yes, it was already the case. But it doesn't harm to document it while we're there. I've added this in v2:

        Note that this
	affects only 'git diff' Porcelain like linkgit:git-diff[1] and
	linkgit:git-log[1], and not lower level commands such as
	linkgit:git-diff-files[1].

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/