Re: [PATCH v2.1] Documentation/diff-config: fix description of diff.renames
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 25, 2016, 18:18 UTC
- Message-ID
- <xmqqoab4odq8.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <1456421878-443-1-git-send-email-Matthieu.Moy@imag.fr>
Matthieu Moy <Matthieu.Moy@imag.fr> writes:
Show 10 quoted lines
> The description was misleading, since "set to any boolean value" include > "set to false", and diff.renames=false does not enable basic detection, > but actually disables it. Also, document that diff.renames only affects > Porcelain. > > Signed-off-by: Matthieu Moy <Matthieu.Moy@imag.fr> > --- > Oops, trivial fix for typo noticed by Felipe. I'm resending just this > one in case Junio wants to pick the latest version but I can obviously > resend the whole if needed.
Heh, I guess people independently spotted the same typo nearly simultaneously ;-)
I think I got this fixed locally (and adjusted the last one to match). Thanks.
Show 25 quoted lines
> > Documentation/diff-config.txt | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/Documentation/diff-config.txt b/Documentation/diff-config.txt > index 6eaa452..b5e9bda 100644 > --- a/Documentation/diff-config.txt > +++ b/Documentation/diff-config.txt > @@ -108,9 +108,13 @@ diff.renameLimit:: > detection; equivalent to the 'git diff' option '-l'. > > diff.renames:: > - Tells Git to detect renames. If set to any boolean value, it > - will enable basic rename detection. If set to "copies" or > - "copy", it will detect copies, as well. > + Whether and how Git detects renames. If set to "false", > + rename detection is disabled. If set to "true", basic rename > + detection is enabled. If set to "copies" or "copy", Git will > + detect copies, as well. Defaults to false. Note that this > + affects only 'git diff' Porcelain like linkgit:git-diff[1] and > + linkgit:git-log[1], and not lower level commands such as > + linkgit:git-diff-files[1]. > > diff.suppressBlankEmpty:: > A boolean to inhibit the standard behavior of printing a space