Re: [PATCH v2 22/24] revision.c: remove implicit dependency on the_index

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 4, 2018, 20:52 UTC
Message-ID: <xmqqsh2p6l43.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <CAGZ79kZi=qt4LyeA4U8nSGKx3_sOEF2m8=K_YNE2JpesF5ybTA@mail.gmail.com>

Stefan Beller <sbeller@google.com> writes:

Show 9 quoted lines

>> -       init_revisions(revs, prefix);
>> +       init_revisions(revs, the_repository, prefix);
>
> Thanks for this patch!
>
> At first I wondered why we put the repository as the second argument,
> but that comes down to personal preference, so I wanted to keep it silent.
> (FWIW: Thinking about it, I'd either go with this order or with (repo,
> prefix, revs)

FWIW, I would also find it more natural to have the_repository as the first parameter, for the same reason why the "index" functions (as opposed to "cache" convenience wrappers) have the_index as the first one.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.