Re: [PATCH v2 24/24] Rename functions to avoid breaking in-flight topics
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 11, 2018, 16:58 UTC
- Message-ID
- <xmqq1sa0q8d8.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <CACsJy8CepuW3DG2AbMiHdoUELHfBmMSZDtPJMzLRHUWwshvivw@mail.gmail.com>
Duy Nguyen <pclouds@gmail.com> writes:
Show 5 quoted lines
> In the end, there's no variant, only one function that always takes > 'struct repository *' and I wanted to keep the shorter name 'rerere'. > But let's go with adding repo_rerere() and deprecating rerere(). If it > turns out later that repo_rerere is too long (or it's repo_xyz > everywhere) then we can do another rename.
Yup, I am not opposed to another rename after the dust settles, but do nto want to see it as part of the series.
Thanks.