Re: [PATCH v2 19/24] submodule.c: remove implicit dependency on the_index

From: Jeff King <peff@peff.net>
Date: Oct 19, 2018, 16:55 UTC
Message-ID: <20181019165532.GA31601@sigill.intra.peff.net>
In-Reply-To: <20181019165301.GA31850@duynguyen.home>

On Fri, Oct 19, 2018 at 06:53:01PM +0200, Duy Nguyen wrote:

Show 5 quoted lines

> > OK, that all makes sense. I need to either drop it or mark it unused to
> > satisfy -Wunused-parameters.
> 
> Aha! I thought you looked deeply into this and was very confused. How
> could you have found the time :D

To be fair, dealing with -Wunused-parameters is its own special time sink. :)

Show 7 quoted lines

> > I think I'd lean toward the former, if
> > it's not likely to be used (even if we add "struct repository" later,
> > the separate index parameter would just go away then).
> 
> Or we could fix it now. Something like this? It adds three the_repository
> (two technically are already there) but deletes eight, which makes me
> happy. It's up to you to decide.

Yeah, that's fine by me, if it's not getting in the way of other related work. The patch you sent looks reasonable.

-Peff