Re: [PATCH 00/21] Kill the_index part 4

From: Stefan Beller <sbeller@google.com>
Date: Aug 27, 2018, 17:32 UTC
Message-ID: <CAGZ79kas5TsCi0yN7mypH53A1iOveGNmQ03BkmspEH1-NfZgBg@mail.gmail.com>
In-Reply-To: <20180826100314.5137-1-pclouds@gmail.com>

On Sun, Aug 26, 2018 at 3:03 AM Nguyễn Thái Ngọc Duy <pclouds@gmail.com> wrote:

Show 5 quoted lines

>
> This continues the journey of getting rid of the_index at least in
> library code. The focus of part 4 is diff code. Since 'struct
> repository *' is passed around more (and even more in part 5), I take
> this opportunity to remove some the_repository references too.

yay! Thank you for continuing on the_index!

Show 5 quoted lines

>
> Besides some small conflicts on 'pu', like the previous part, it also
> breaks 'pu' because of API changes. The fix is trivial though, just
> prepend the_repository as the first argument for the broken function
> calls.

This sounds like a problem. I said the same when sending the object store lookup series, which ended via 3a2a1dc1707 (Merge branch 'sb/object-store-lookup', 2018-08-02) in master, but I do recall Junio being somewhat unhappy about it[1].

By just adding the argument to the function, it might merge easily but not compile, which would have to be fixed up; and that object store series seemed to touch a lot of functions that were also used in series in-flight.

I have since lost track of the refactoring and focused more on submodules again, but plan to come back to more 'repositorification'.

> After this and ~20 more patches in part5, the_index is gone from
> library code.

This sounds promising! I'll take a look.

>  diff.c                 | 259 +++++++++++++++++++++++------------------

Ugh? That sounds like there is an interesting change coming.

Stefan