Re: [PATCH 6/8] checkout: add --cached option

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 19, 2019, 19:07 UTC
Message-ID: <xmqqsgwj1ts9.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <CABPp-BGkJOgKqE_vHsA1fkjQ80U10Hv7-HCvScq7WOgj1UF9=Q@mail.gmail.com>

Elijah Newren <newren@gmail.com> writes:

Show 6 quoted lines

> Overall this looks good, but there's just one part that confuses me.
> Here you seem to suggest that if you pass --source but neither --index
> or --worktree that both the index and working tree will be written to.
> Why are "restored" changes considered ready for commit?  That seems
> confusing to me (and was one of the bugs of checkout, IMO).  See also
> second half of https://public-inbox.org/git/xmqq1s6yezk3.fsf@gitster-ct.c.googlers.com/

As long as worktree-only mode does not lose track of a previously-untracked path in the index (perhaps use the i-t-a bit), I do not have a strong objection against making the worktree-only mode the default.