Re: [PATCH 2/8] entry: factor out unlink_entry function

From: Duy Nguyen <pclouds@gmail.com>
Date: Dec 10, 2018, 17:27 UTC
Message-ID: <CACsJy8BgceLwH71SkkA0n_etrOrC8ucGBpkK2+RB+PU3F=0RgQ@mail.gmail.com>
In-Reply-To: <CABPp-BE15jfe76q3hqSxnifv8MNB1e6_GDT=5=ZmTE__XuTmLw@mail.gmail.com>

On Mon, Dec 10, 2018 at 6:23 PM Elijah Newren <newren@gmail.com> wrote:

Show 7 quoted lines

> > I wonder if we should move the 'removal' variable in symlinks to
> > 'struct checkout' to reduce another global variable. But I guess
> > that's the problem for another day. It's not the focus of this series.
>
> "move the 'removal' variable in symlinks"?  I'm having a really hard
> time parsing that phrase and the sentence it's embedded in.  Could you
> reword for me Duy?

Sorry s/in symlinks/&.c/. There's a global variable named 'removal' in symlinks.c which is used by schedule_dir_for_removal() and this function in turn is used by unlink_entry().

-- 
Duy

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.