Re: [PATCH 4/8] read-cache: add invalidate parameter to remove_marked_cache_entries

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 11, 2018, 02:42 UTC
Message-ID: <xmqq7eggn5rk.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <CACsJy8AiQvu8W4=2HLKMdg+n2HiDrcLvKPRurKvziXaJdqefRg@mail.gmail.com>

Duy Nguyen <pclouds@gmail.com> writes:

> I'm still a bit scared of this invalidation business in unpack-trees.

I too was (and I suspect that I would realize that I still am, if I take another fresh look at the current code) afraid when I did the cache-tree work and decided to invalidate it as a whole upfront.

Show 7 quoted lines

> The thing is, we handle two separate index_state there, src_index and
> result and invalidation has to be done on the right one (because index
> extensions are on src_index until the very end of unpack-trees;
> invalidating on 'result' would be no-op and wrong).
> ...
> Yeah I think it's because cache-tree and untracked cache are already
> properly invalidated. ...