Re: [PATCH 3/8] entry: support CE_WT_REMOVE flag in checkout_entry

From: Duy Nguyen <pclouds@gmail.com>
Date: Dec 12, 2018, 06:16 UTC
Message-ID: <CACsJy8C6VuH=hr9JE+AXeqU5V9RwouzZSb5+jV++GHU3myoDTA@mail.gmail.com>
In-Reply-To: <xmqqbm5sn6f6.fsf@gitster-ct.c.googlers.com>

On Tue, Dec 11, 2018 at 3:28 AM Junio C Hamano <gitster@pobox.com> wrote:

Show 15 quoted lines

>
> Duy Nguyen <pclouds@gmail.com> writes:
>
> >> +       if (ce->ce_flags & CE_WT_REMOVE) {
> >> +               if (topath)
> >> +                       BUG("Can't remove entry to a path");
> >> +               unlink_entry(ce);
> >> +               return 0;
> >> +       }
> >
> > This makes the path counting in nd/checkout-noisy less accurate. But
> > it's not your fault of course.
>
> When we check out absense of one path, how do we want to count it?
> Do we say "one path checked out?" when we remove one path?

It is still "checked out" according to this non-overlay concept. Although we could make it clear by saying "5 paths updated, 2 deleted" (but that may make us say "3 paths added" as well, hmm). Or maybe just "%d paths updated" where updates include file creation and deletion.

-- 
Duy