Re: [PATCH v3 7/8] checkout: introduce --{,no-}overlay option
- From
Thomas Gummerer <t.gummerer@gmail.com>
- Date
- Jan 24, 2019, 22:08 UTC
- Message-ID
- <20190124220801.GC11293@hank.intra.tgummerer.com>
- In-Reply-To
- <20190123204721.GB34357@google.com>
On 01/23, Jonathan Nieder wrote:
Show 15 quoted lines
> Thomas Gummerer wrote: > > On 01/22, Jonathan Nieder wrote: > > > As checkout is a porcelain command, I had hoped it would be okay to > > also have this as a configuration option, for the time before > > 'checkout-paths' exists and while I'm getting used to actually typing > > 'checkout-paths' instead of 'checkout'. However I get that there may > > be scripts that are using git checkout, and expect the previous > > behaviour, so I'm also okay with dropping the config option for now. > > Yes, if we have no plan for flipping the default later, then I would > prefer to eliminate the config option. Scripts very frequently use > human-facing commands like "git checkout" when they want the command > to produce (unparsable) friendly output to show to humans, and I don't > think we've provided a good alternative for that use case.
Ok, I'm happy to drop that for now, and possibly re-introduce that with another series to start flipping the default. I'll probably wait for Duy's checkout-paths command first though, and possibly send a series later.
Junio, do you just want to revert the patch (1495ff7da5 ("checkout: introduce checkout.overlayMode config", 2019-01-08)), or would you prefer me sending a patch for that?
Show 12 quoted lines
> > If we still want to make this the default even after 'checkout-paths' > > exists, the plan you outline below sounds good to me, though maybe we > > can make the "flip the default" step once we decide to release git > > 3.0. > > I would really like this, so I might write a series for it. Please > don't wait for me, though --- feel free to send any patches you're > thinking about and we can work together or I can just appreciate your > work. ;-) > > Sincerely, > Jonathan