Re: [PATCH v5 4/4] init: provide useful advice about init.defaultBranch
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 2, 2021, 22:25 UTC
- Message-ID
- <xmqqsg6eds5e.fsf@gitster.c.googlers.com>
- In-Reply-To
- <20210202212451.GC2091@szeder.dev>
SZEDER Gábor <szeder.dev@gmail.com> writes:
Show 9 quoted lines
>> - "${GIT_TEST_INSTALLED:-$GIT_EXEC_PATH}/git$X" init \
>> + "${GIT_TEST_INSTALLED:-$GIT_EXEC_PATH}/git$X" -c \
>> + init.defaultBranch="${GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME-master}" \
>> + init \
>> "--template=$GIT_BUILD_DIR/templates/blt/" >&3 2>&4 ||
>
> This breaks GIT_TEST_INSTALLED when the given Git version doesn't yet
> contain 8b1fa77867 (Allow passing of configuration parameters in the
> command line, 2010-03-26):Yes, but test-installed is about running an old version of Git on the current Git test suite. In the tests we make liberal use of "git -c <var>=<val>", which such an old version of Git has no chance of passing. So...